Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store test screenshots for ui tests #1906

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Store test screenshots for ui tests #1906

merged 2 commits into from
Dec 9, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Dec 9, 2024

This PR allows us to store screenshots for failed UI tests. We'll only create the artefact when a test fails and store it for one day.

Example: https://github.com/hashicorp/vscode-terraform/actions/runs/12234779622/job/34124676411?pr=1906#step:11:23

@dbanck dbanck force-pushed the c-store-test-screenshots branch 4 times, most recently from a810766 to 40407cc Compare December 9, 2024 11:34
@dbanck dbanck marked this pull request as ready for review December 9, 2024 11:35
@dbanck dbanck requested a review from a team as a code owner December 9, 2024 11:35
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@dbanck dbanck force-pushed the c-store-test-screenshots branch from 40407cc to 3b948e0 Compare December 9, 2024 14:02
@dbanck dbanck merged commit 1154b9b into main Dec 9, 2024
13 checks passed
@dbanck dbanck deleted the c-store-test-screenshots branch December 9, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants