-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't enable or disable extension per workspace #1629
Comments
Hey @br3ndonland thanks for bringing this to our attention. This was not intended and I don't immediately know what we did yet that caused it to not be able to be disabled/enabled per workspace, but I'm going to try and figure out. |
Thanks for looking into this @jpogran. Is there any update? I still can't enable the extension per-workspace, even with the pre-release version. It's really obnoxious. |
Apologies on the delayed reply, I was not able to update the ticket before the recent holidays. I opened microsoft/vscode-discussions#930 to ask why this behavior occurs. In short, because we advertise an authentication provider, we cannot be enabled or disabled per workspace. I'm not particularly happy about the reasoning or lack of documentation/warning about this, but it's outside of my ability to control and I have to work with what I've got. Now that the holidays are over, this is back on my plate and I'm going to see what I can do to resolve this going forward. Unfortunately I still do not have a workaround at this time because of the way VS Code works. |
Thanks for the update @jpogran. I totally understand that some aspects of the VSCode Extensions API are outside your control, and appreciate your efforts with the upstream discussion in microsoft/vscode-discussions#930. If you figure out a solution and need some help testing development builds of the extension, I'm happy to help. |
Hi @br3ndonland, I just published a pre-release version of the extension with a potential fix. If you validate that it works for you, I'll merge it to main and publish a stable version soon. |
@jpogran , fix worked for me as well FYI: It seems that you version that you used to publish the fix (v2.29.2024011610) is less than the latest pre-release version (v2.29.2024011611): |
v2.29.2024011610 looks good, thanks @jpogran! |
The fix works for me! But I had to manually select the version v2.29.2024011610 as suggested by @panfiva. |
Thanks all for the feedback. We've merged this and released it in the latest stable: 2.29.3. @br3ndonland let me know if things don't work for you in stable. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Extension Version
v2.29.0
VS Code Version
Version: 1.84.2
Commit: 1a5daa3a0231a0fbba4f14db7ec463cf99d7768e
Date: 2023-11-09T10:52:57.054Z
Electron: 25.9.2
ElectronBuildId: 24603566
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin arm64 23.0.0
Operating System
macOS Sonoma 14.0
Terraform Version
Terraform v1.5.7 on darwin_arm64
Steps to Reproduce
Expected Behavior
As of 2.28.2 (2023-10-16), it was possible to enable or disable the extension per workspace in VSCode.
Actual Behavior
As of 2.29.0 (2023-11-08), the extension cannot be enabled or disabled per workspace in VSCode.
This change does not appear to be mentioned in the release notes for 2.29.0.
Terraform Configuration
No response
Project Structure
No response
Gist
No response
Anything Else?
No response
Workarounds
Downgrade to extension v2.28.2
References
Help Wanted
Community Note
The text was updated successfully, but these errors were encountered: