Use of the AWS Global STS endpoint

[liwadman]

Describe the bug
It looks like you're hardcoding the AWS Global STS endpoint here:

vault/builtin/credential/aws/path_login.go

Line 297 in bce085b

endpoint := "https://sts.amazonaws.com"

You should never do this - there is no valid usecase to use the global endpoint. Customers should be able to specify which regional endpoint their vault is using.

To Reproduce
see code link

Expected behavior

Let customers specify a regional endpoint, or use the regional endpoint that is specified in the GCI request.

Environment:
N/A

Vault server configuration file(s):

# Paste your Vault config here.
# Be sure to scrub any sensitive values

Additional context

Please feel free to reach out, I am with AWS Identity.