Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ephemeral resource merger for Terraform version < 1.10 #431

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Dec 11, 2024

Our integration testing at hashicorp/vscode-terraform#1914 has discovered a crash in the latest terraform-ls release (0.36.1).

This crash didn't occur in 0.36.0 because when we shipped that version there were no ephemeral resources in any of the provider schemas. Now that many providers have released some ephemeral resources, we hit that code path and panicked.

This PR fixes the issues and adds testing with different versions of Terraform.

@dbanck dbanck added the bug Something isn't working label Dec 11, 2024
@dbanck dbanck marked this pull request as ready for review December 12, 2024 10:17
@dbanck dbanck requested a review from a team as a code owner December 12, 2024 10:17
@dbanck dbanck merged commit 081547f into main Dec 12, 2024
5 checks passed
@dbanck dbanck deleted the b-fix-ephemeral-for-earlier-tfversions branch December 12, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants