Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sub_path_expr to volume_mount #925

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

benjah1
Copy link

@benjah1 benjah1 commented Jul 21, 2020

Description

Add sub_path_expr to volume_mount.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)
root@ubuntu-bionic:/app# KUBE_CTX=kind-kind TESTARGS="-run '^TestAccKubernetesPod_.*volume.*'" make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test "./kubernetes" -v -run '^TestAccKubernetesPod_.*volume.*' -timeout 120m
=== RUN   TestAccKubernetesPod_with_volume_mount
--- PASS: TestAccKubernetesPod_with_volume_mount (21.84s)
=== RUN   TestAccKubernetesPod_with_volume_mount_sub_path_expr
--- PASS: TestAccKubernetesPod_with_volume_mount_sub_path_expr (21.27s)
=== RUN   TestAccKubernetesPod_with_cfg_map_volume_mount
--- PASS: TestAccKubernetesPod_with_cfg_map_volume_mount (24.52s)
=== RUN   TestAccKubernetesPod_with_empty_dir_volume
--- PASS: TestAccKubernetesPod_with_empty_dir_volume (9.19s)
PASS
ok      github.com/hashicorp/terraform-provider-kubernetes/kubernetes   76.880s

Will post a full testacc run once finished.

References

#920

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@benjah1
Copy link
Author

benjah1 commented Jul 22, 2020

full testacc run with kind.
https://gist.github.com/benjah1/1e634f0f14aec980acd6816d9ea14f82

@aareet aareet linked an issue Jul 22, 2020 that may be closed by this pull request
@benjah1
Copy link
Author

benjah1 commented Sep 29, 2020

Resolved conflict.

Hi @aareet, is there anything I can do to help merging this in?

@rubenqba
Copy link

Hi, any news about this feature?

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 22, 2020

CLA assistant check
All committers have signed the CLA.

Base automatically changed from master to main March 23, 2021 15:53
@jamesarems
Copy link

Any update on this feature ?

@way2203
Copy link

way2203 commented Sep 5, 2022

Hi, any news about this feature?

@jsm3031
Copy link

jsm3031 commented Apr 20, 2023

I also need this merged

@BBBmau BBBmau requested a review from a team as a code owner December 5, 2023 12:50
@github-actions github-actions bot added size/XL and removed size/M labels Dec 5, 2023
@david-garcia-garcia
Copy link

Four years later, this is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support of sub_path_expr for container volume_mount
9 participants