Adding traffic_distribution field #2625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaylonmcShan03
force-pushed
the
v3-major-release
branch
from
89a16b6
to
e045752
Compare
JaylonmcShan03
force-pushed
the
add-traffic-distribution-field
branch
from
5aad8b0
to
7ec763b
Compare
arybolovlev
reviewed
Nov 21, 2024
.changelog/2625.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:enhancement | |||
| Added the `traffic_distribution` field to the `kubernetes_service_v1` resource | |||
There was a problem hiding this comment.
I would suggest to use imperative voice here and add kubernetes_service too, since both resources refer to the same code:
```release-note:enhancement
`resource/kubernetes_service`: add a new field `traffic_distribution`.
```
```
`resource/kubernetes_service_v1`: add a new field `traffic_distribution`.
```
| Description: "Specifies the preferred strategy for distributing traffic to Service endpoints. When set to PreferClose, the Kubernetes will prioritize routing traffic to endpoints that are topologically closer", | ||
| Optional: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "PreferClose", |
There was a problem hiding this comment.
I would suggest importing such predefined words from Kubernetes code.
There was a problem hiding this comment.
@arybolovlev Wow, that's a clever approach! Would this be considered best practice for the future? Due to the k8s api were to update / expand on the traffic_distrubtion field with additional options, our code would automatically align with those changes?
arybolovlev
reviewed
Nov 21, 2024
| resourceName := "kubernetes_service_v1.test" | ||
|
|
||
| resource.ParallelTest(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, |
There was a problem hiding this comment.
Please add here skipIfClusterVersionLessThan to make sure these test runs on Kubernetes 1.31+ only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #2581
This PR introduces the traffic_distribution field to the kubernetes_service_v1 resource. This field, introduced in Kubernetes v1.31 provides a way to influence traffic routing within a Kubernetes Service by specifying a preference for traffic distribution.
Acceptance tests
Output from acceptance testing:
Release Note
Release note for CHANGELOG:
References
Community Note