Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor muxing 1 : Re-use same config to configure the SDK and PF providers, fix VCR testing #20426

Conversation

modular-magician
Copy link
Collaborator

Fixes #19197
Fixes #18774
Fixes #20280

Summary

This PR:

  • Changes how the plugin-framework implementation of the provider is configured
    • Before: Parallel implementation of configuration logic that parses user inputs and populates a fwtransport.FrameworkProviderConfig struct
    • After: The configure function obtains an already populated transport_tpg.Config struct from the SDK provider, with no duplication of logic to process user inputs.
  • Changes code defining the VCR system to accommodate the change above
  • Makes necessary changes to the data sources currently implemented with the plugin-framework
    • These now expect to receive a transport_tpg.Config struct
    • Any provider-level values are now in the old type system, and require thought about where we convert between those type systems.

Things to pay attention to during review/testing

  • What acceptance tests need to be updated now that the PF provider is configured in a SDK-like way?
  • Are only changes just to the test required, or do the failures indicate user-facing changes in behaviour?
  • Tests

provider: refactored how the provider configuration is handled internally

Derived from GoogleCloudPlatform/magic-modules#11903

…oviders, fix VCR testing (hashicorp#11903)

[upstream:4760ae5c1899423a0b4a3c4984df853f5b65960d]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner November 21, 2024 16:51
@modular-magician modular-magician merged commit 2f1b7e3 into hashicorp:main Nov 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment