Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply new labels model to more resources (part 1) #15877

Conversation

modular-magician
Copy link
Collaborator

  1. Handle the case that the labels field is inside a flatten object (google_bigquery_job)
  2. Make effective_labels immutable if labels filed is immutable
  3. Apply the labels model to more MMV1 resources

Release Note Template for Downstream PRs (will be copied)


Derived from GoogleCloudPlatform/magic-modules#8950

* Apply new labels model to more resources (part 1)

* Handle labels field inside flatten object

* Fix the tests for datasource

* Fix typo

* Fix typo

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 23a2c59 into hashicorp:FEATURE-BRANCH-major-release-5.0.0 Sep 15, 2023
3 checks passed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
@modular-magician modular-magician deleted the downstream-pr-0ef602f678611b77172a342e8e2980633054ed01 branch November 17, 2024 00:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant