Create sweepers for oracledatabase resources

[SarahFrench]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
• Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.
• If an issue is assigned to a user, that user is claiming responsibility for the issue.
• Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Oracle database-related acceptance tests have been failing due to tests using non-unique names and name clashes happening with dangling resources. This can be addressed by making the resources' names unique, but the resources cannot be given the tf-test- prefix to make them sweepable too. This is because the resources' names need to start with the prefix ofake- to ensure a 'dummy' resource is provisioned during the test instead of a full resource.

To avoid manual toil of removing dangling resources there should be a sweeper for these resources that can identify resources from acceptance tests that have the ofake- prefix. I suggest adding ofake-tf-test- to the list of prefixes that identify resources as sweepable (and then make some sweepers for these resources!)

Relevant code:

• func IsSweepableTestResource
• testResourcePrefixes - the list of prefixes that mark a resource as sweepable. ofake-tf-test- or ofake- would need to be added here.

New or Affected Resource(s)

• google_oracledatabase_*

Potential Terraform Configuration

References

Test failure ticket where issue arose: #19983