Problems with plugin-framework implemented provider configuration

[SarahFrench]

What kind of contribution is this issue about?

Other (specify in details)

Details

Background

The provider was muxed in early 2023, with v4.53.0 being the first release to contain parallel SDK and plugin-framework (PF) implementations. A bunch of issues were discovered soon after release and the most significant were addressed then, but other issues have remained due to reduced impact (in the context of us pausing to migrate new resources and data sources to the PF).

These are the data sources that have been migrated to the plugin framework in the past. No resources were migrated:

(GA/Beta)
google_client_config
google_client_openid_userinfo
google_dns_managed_zone
google_dns_managed_zones
google_dns_record_set
google_dns_keys

(Beta only)
google_firebase_web_app_config
google_firebase_android_app_config
google_firebase_apple_app_config

Problems

Here is a list of outstanding, recent issues where the root cause is believed to be how the provider was muxed in 2023:

• ✅ VCR testing doesn't work following muxing, if an acc test combines SDK and PF implemented stuff. 100% SDK tests work ok.
  • VCR test(s) fail during replay: Framework converted resources #14158
  • We can see this is resolved in this PR, where VCR tests now pass when they mix SDK and PF implemented resources and datasources: Refactor muxing 1 : Re-use same config to configure the SDK and PF providers, fix VCR testing GoogleCloudPlatform/magic-modules#11903 (comment)
• Some auth methods experience problems using PF implemented stuff
  • ✅ data.google_dns_managed_zone always fails with "Post "https://oauth2.googleapis.com/token": context canceled" #16832
    • Temporarily fixed by reverting DNS data sources back to the SDK
    • Manual testing confirmed that my muxing fixes PR will address this
  • google_client_config data-source fails to issue token : oauth2/google: invalid response from Secure Token Server: Post "https://sts.googleapis.com/v1/token": context canceled #18774
• 🟥 Problems with the provider configuration logic?
  • "billing_project" in provider configuration ignored if GOOGLE_CLOUD_QUOTA_PROJECT environment variable is set #17882
  • This wasn't due to the muxing, instead it was due to a change in a client library we use that we pulled into the provider in a release just before the muxing was added: "billing_project" in provider configuration ignored if GOOGLE_CLOUD_QUOTA_PROJECT environment variable is set #17882 (comment)
• Universe domain not used when configuring the PF provider
  • Universe domain is not used when configuring the plugin-framework provider implementation #20280
  • This will be addressed by my muxing fixes PR; the logic implemented for the SDK provider only will now affect both provider implementations within the Google provider

References

No response

[SarahFrench]

I've done some manual testing here #16832 (comment) to confirm that the muxing fixes are doing to address the issue(s) with auth methods linked above.