Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Persistence Configuration on Memory Store Redis Cluster #17999

Open
CharlKlein opened this issue May 1, 2024 · 7 comments
Open

Comments

@CharlKlein
Copy link

CharlKlein commented May 1, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • Please do not leave +1 or me too comments, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.
  • If an issue is assigned to a user, that user is claiming responsibility for the issue.
  • Customers working with a Google Technical Account Manager or Customer Engineer can ask them to reach out internally to expedite investigation and resolution of this issue.

Description

Persistence Configuration has been made available in GCP. Would it be appropriate to add it to the Module while the feature is still pre-GA or only after the GA Release

Pre-GA release date: 5 April 2024
Article: https://cloud.google.com/memorystore/docs/cluster/persistence-overview

Thanks

New or Affected Resource(s)

  • google_redis_cluster

Potential Terraform Configuration

resource "google_redis_cluster" "cluster-ha" {
  name = "its-a-cluster"
  # Omitted for brevity

  persistence_config { # One of the Options must be specified either rdb_config or aof_config

    rdb_config {
      rdb_snapshot_period    = "TWELVE_HOURS"         # Possible values are: ONE_HOUR, SIX_HOURS, TWELVE_HOURS, TWENTY_FOUR_HOURS.
      rdb_next_snapshot_time = "2014-10-02T15:01:23Z" #Timestamp in RFC3339 UTC "Zulu" format
    }

    aof_config {
      append_fsync = "ALWAYS" # Possible values are: NO, ALWAYS, EVERYSEC.
    }
  }
}

References

b/339026611

@github-actions github-actions bot added forward/review In review; remove label to forward service/redis-cluster labels May 1, 2024
@BBBmau BBBmau added this to the Goals milestone May 6, 2024
@BBBmau BBBmau added size/s and removed forward/review In review; remove label to forward labels May 6, 2024
@StarpTech
Copy link

Hi, any updates on this? What's missing to add support for it?

@ashokkavuri
Copy link

any update on this ?

@kenzik
Copy link

kenzik commented Oct 29, 2024

Would like to see the persistence option, as well as replication options, eg. --cross-cluster-replication-role & --primary-cluster

@fewtrell
Copy link

Hello I'll be submitting a pull request for persistence support shortly.

@fewtrell
Copy link

fewtrell commented Oct 31, 2024

@fewtrell
Copy link

This should be fully rolled out now:
dcd2690

@fewtrell
Copy link

I think I don't have permissions to actually close this specific issue out thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants