Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test(s): TestAccCloudRunService permadiff on template.metadata.annotations #16161

Closed
melinath opened this issue Oct 6, 2023 · 3 comments

Comments

@melinath
Copy link
Collaborator

melinath commented Oct 6, 2023

Failure rates

  • 100% since 2023-10-02

Impacted tests

  • TestAccCloudRunService_cloudRunServiceMulticontainerExample
  • TestAccCloudRunService_cloudRunServiceSqlExample

Affected Resource(s)

  • google_cloud_run_service

Nightly build test history

Message(s)

vcr_utils.go:152: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        Terraform will perform the following actions:
          # google_cloud_run_service.default will be updated in-place
          ~ resource "google_cloud_run_service" "default" {
                id                         = "locations/us-central1/namespaces/test-project/services/tf-test-cloudrun-srvk9fcjefnff"
                name                       = "tf-test-cloudrun-srvk9fcjefnff"
                # (4 unchanged attributes hidden)
              ~ metadata {
                  + labels                = {}
                    # (9 unchanged attributes hidden)
                }
              ~ template {
                  ~ metadata {
                      ~ annotations = {
                          - "run.googleapis.com/startup-cpu-boost"      = "true" -> null
                            # (2 unchanged elements hidden)
                        }
                        # (2 unchanged attributes hidden)
                    }
                  ~ spec {
                        # (3 unchanged attributes hidden)
                      ~ containers {
                          + args    = []
                          + command = []
                            name    = "hello-1"
                            # (1 unchanged attribute hidden)
                            # (4 unchanged blocks hidden)
                        }
                      ~ containers {
                          + args    = []
                          + command = []
                            name    = "hello-2"
                            # (1 unchanged attribute hidden)
                            # (4 unchanged blocks hidden)
                        }
                        # (1 unchanged block hidden)
                    }
                }
                # (1 unchanged block hidden)
            }
        Plan: 0 to add, 1 to change, 0 to destroy.

This seems likely to be due to a server-side change. No difference in the POST request body between successful and failing days:

{
 "apiVersion": "serving.knative.dev/v1",
 "kind": "Service",
 "metadata": {
  "name": "tf-test-cloudrun-srvys38ln296l"
 },
 "spec": {
  "template": {
   "metadata": {
    "annotations": {
     "autoscaling.knative.dev/maxScale": "1000",
     "run.googleapis.com/client-name": "terraform",
     "run.googleapis.com/cloudsql-instances": "test-project:us-east1:tf-test-cloudrun-sqlys38ln296l"
    }
   },
   "spec": {
    "containers": [
     {
      "image": "us-docker.pkg.dev/cloudrun/container/hello"
     }
    ]
   }
  }
 }
}

b/303986862

@github-actions github-actions bot added forward/review In review; remove label to forward service/run labels Oct 6, 2023
@melinath melinath removed the forward/review In review; remove label to forward label Oct 6, 2023
@bravominski
Copy link

Hi, @melinath , I had some issue with my github account linked to work email. Could you double check if this is still failing?

Supposedly the issue has been fixed as of end of last week.

@melinath
Copy link
Collaborator Author

Looks like this is passing now - thanks!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants