-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad Doc: Example Usage - Pubsub Subscription Different Project #11642
Bad Doc: Example Usage - Pubsub Subscription Different Project #11642
Comments
BOD: verify this works as intended as-is, and if it does feel free to remove |
other examples are also wrong. |
It looks like the tests for this example are currently skipped - we should enable them and fix the example as described above. |
This error still exists in the docs. It was introduced in 2019 in @rileykarson 's PR GoogleCloudPlatform/magic-modules#2342 which changed from |
PR GoogleCloudPlatform#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR GoogleCloudPlatform#2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024.
GoogleCloudPlatform/magic-modules#9637 should fix it. |
…ll examples cross-project-friendly (#9637) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
…ll examples cross-project-friendly (#9637) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (#9637) (#621) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (#9637) * Fix "Pubsub Subscription Different Project" example PR hashicorp#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR hashicorp#2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (hashicorp#9637) * Fix "Pubsub Subscription Different Project" example PR hashicorp#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR hashicorp#2342. Fixes hashicorp#11642. Fixes hashicorp#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (#9637) (#6758) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (#9637) (#16806) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes #11642. Fixes #6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (#9637) * Fix "Pubsub Subscription Different Project" example PR GoogleCloudPlatform#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR GoogleCloudPlatform#2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]> [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (#9637) (#1794) * Fix "Pubsub Subscription Different Project" example PR #2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR #2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- [upstream:b3ae8dcd7e476f796a8b1ba67ce63cea711be127] Signed-off-by: Modular Magician <[email protected]>
…ll examples cross-project-friendly (GoogleCloudPlatform#9637) * Fix "Pubsub Subscription Different Project" example PR GoogleCloudPlatform#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR GoogleCloudPlatform#2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
…ll examples cross-project-friendly (GoogleCloudPlatform#9637) * Fix "Pubsub Subscription Different Project" example PR GoogleCloudPlatform#2342 changed this example from using `id` to `name`, which removed the project ID from the topic. However, the point of this example is to show how to set up a cross-project subscription, so the example no longer works. This change reverts that change from PR GoogleCloudPlatform#2342. Fixes hashicorp/terraform-provider-google#11642. Fixes hashicorp/terraform-provider-google#6024. * Make all examples cross-project-friendly and update topic description * Fix typo --------- Co-authored-by: Stephen Lewis (Burrows) <[email protected]>
Affected Resource(s)
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/pubsub_subscription#example-usage---pubsub-subscription-different-project
b/302797491
The text was updated successfully, but these errors were encountered: