From 2bc8d5bbb57d8595aa0827b5dc8800cd27d52797 Mon Sep 17 00:00:00 2001 From: The Magician Date: Fri, 27 Oct 2023 09:20:29 -0700 Subject: [PATCH] skip VCR for tests that create bigtable instance (#9369) (#6580) [upstream:78ea2f9f71bc64634a0f88553e563b239251f310] Signed-off-by: Modular Magician --- .changelog/9369.txt | 3 +++ google-beta/services/bigquery/resource_bigquery_table_test.go | 2 ++ .../bigtable/resource_bigtable_app_profile_generated_test.go | 3 +++ .../services/bigtable/resource_bigtable_gc_policy_test.go | 1 + 4 files changed, 9 insertions(+) create mode 100644 .changelog/9369.txt diff --git a/.changelog/9369.txt b/.changelog/9369.txt new file mode 100644 index 0000000000..8ec013c069 --- /dev/null +++ b/.changelog/9369.txt @@ -0,0 +1,3 @@ +```release-note:none + +``` diff --git a/google-beta/services/bigquery/resource_bigquery_table_test.go b/google-beta/services/bigquery/resource_bigquery_table_test.go index 7d77503b31..f2f22432d3 100644 --- a/google-beta/services/bigquery/resource_bigquery_table_test.go +++ b/google-beta/services/bigquery/resource_bigquery_table_test.go @@ -1059,6 +1059,8 @@ func TestAccBigQueryExternalDataTable_CSV_WithSchema_UpdateAllowQuotedNewlines(t } func TestAccBigQueryDataTable_bigtable(t *testing.T) { + // bigtable instance does not use the shared HTTP client, this test creates an instance + acctest.SkipIfVcr(t) t.Parallel() context := map[string]interface{}{ diff --git a/google-beta/services/bigtable/resource_bigtable_app_profile_generated_test.go b/google-beta/services/bigtable/resource_bigtable_app_profile_generated_test.go index 07067d4141..d771a3c5cc 100644 --- a/google-beta/services/bigtable/resource_bigtable_app_profile_generated_test.go +++ b/google-beta/services/bigtable/resource_bigtable_app_profile_generated_test.go @@ -31,6 +31,7 @@ import ( ) func TestAccBigtableAppProfile_bigtableAppProfileAnyclusterExample(t *testing.T) { + acctest.SkipIfVcr(t) t.Parallel() context := map[string]interface{}{ @@ -95,6 +96,7 @@ resource "google_bigtable_app_profile" "ap" { } func TestAccBigtableAppProfile_bigtableAppProfileSingleclusterExample(t *testing.T) { + acctest.SkipIfVcr(t) t.Parallel() context := map[string]interface{}{ @@ -150,6 +152,7 @@ resource "google_bigtable_app_profile" "ap" { } func TestAccBigtableAppProfile_bigtableAppProfileMulticlusterExample(t *testing.T) { + acctest.SkipIfVcr(t) t.Parallel() context := map[string]interface{}{ diff --git a/google-beta/services/bigtable/resource_bigtable_gc_policy_test.go b/google-beta/services/bigtable/resource_bigtable_gc_policy_test.go index c991626734..d8733f0fd5 100644 --- a/google-beta/services/bigtable/resource_bigtable_gc_policy_test.go +++ b/google-beta/services/bigtable/resource_bigtable_gc_policy_test.go @@ -168,6 +168,7 @@ func TestAccBigtableGCPolicy_multiplePolicies(t *testing.T) { } func TestAccBigtableGCPolicy_gcRulesPolicy(t *testing.T) { + // bigtable instance does not use the shared HTTP client, this test creates an instance acctest.SkipIfVcr(t) t.Parallel()