Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static field initialization from a non-static method in the virtualmap package #15946

Open
thenswan opened this issue Oct 10, 2024 · 1 comment
Labels
Platform Data Structures Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.

Comments

@thenswan
Copy link
Contributor

This is a follow-up for #15562. After it will be merged, there will be static field initialization from a non-static method in the following classes:

  1. VirtualNodeCache -- static getCleaningPool will be invoked from a non-static method and initialize cleaningPool.
  2. VirtualHasher -- static getHashingPool will be invoked from a non-static method and initialize hashingPool.

(more detailed info will be in method-level docs)

The task is to refactor it so that there are no static fields but just instance fields.

@artemananiev artemananiev added Tech Debt Reduced Issues which reduce technical debt. Platform Data Structures Platform Tickets pertaining to the platform labels Oct 10, 2024
@artemananiev
Copy link
Member

One option to fix this is to wait till #14395 and make the pools above instance fields rather than static fields. There will be just on VirtualMap (per node), and it will have one hasher and one node cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Data Structures Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants