Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Define throttle for GetBalance queries #15930

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

vtronkov
Copy link
Contributor

@vtronkov vtronkov commented Oct 9, 2024

Description:
Adding new CryptoGetAccountBalance throttle limit

Related issue(s):

Fixes #15929

@vtronkov vtronkov changed the title add BalanceQueryLimits throttle limit Define throttle for GetBalance queries Oct 9, 2024
@vtronkov vtronkov self-assigned this Oct 9, 2024
@vtronkov vtronkov changed the title Define throttle for GetBalance queries feat: Define throttle for GetBalance queries Oct 9, 2024
@vtronkov vtronkov added this to the v0.56 milestone Oct 9, 2024
Signed-off-by: Valentin Tronkov <[email protected]>
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.16%. Comparing base (872ca1a) to head (c508aa9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15930   +/-   ##
==========================================
  Coverage      58.16%   58.16%           
  Complexity     21628    21628           
==========================================
  Files           2788     2788           
  Lines         109566   109566           
  Branches       11198    11198           
==========================================
  Hits           63726    63726           
  Misses         41979    41979           
  Partials        3861     3861           
Files with missing lines Coverage Δ
.../java/com/hedera/node/config/data/StatsConfig.java 100.00% <ø> (ø)

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (872ca1a) 109383 67477 61.69%
Head commit (c508aa9) 109383 (+0) 67477 (+0) 61.69% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15930) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define throttle for GetBalance queries
1 participant