Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around PBJ issues so protobufs compile in services repo (e.g. not having nested proto definitions) #13897

Closed
Tracked by #13347
mhess-swl opened this issue Jun 17, 2024 · 1 comment
Assignees

Comments

@mhess-swl
Copy link
Member

mhess-swl commented Jun 17, 2024

Currently the block stream protos don't compile in the services codebase. We need to get them compiling, even if we use some temporary workarounds.

Related, but possibly not the cause, there are a number of issues filed in the PBJ repo that may be impacting said compile-ability:

Of course, there may be other issues as well. These issues may be a good starting point, though.

@mhess-swl mhess-swl changed the title Work around PBJ issues so protobufs compile in services repo (e.g. not having nested proto definitions. See list of issues here) Work around PBJ issues so protobufs compile in services repo (e.g. not having nested proto definitions) Jun 17, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Jun 17, 2024
@mhess-swl mhess-swl moved this from 📋 Backlog to 👷🏼‍♀️ In Progress in Services Team Jun 17, 2024
@derektriley derektriley self-assigned this Jun 18, 2024
@derektriley derektriley moved this from 👷🏼‍♀️ In Progress to ✅ Done in Services Team Jun 25, 2024
@derektriley
Copy link
Contributor

After speaking with Joseph created a PR to address compilation issues with PBJ.
Confirmed I could compile the block stream protobufs with PBJ from hedera-services.

hashgraph/hedera-protobufs#382

@derektriley derektriley moved this from ✅ Done to 👀 In Review in Services Team Jun 26, 2024
@derektriley derektriley moved this from 👀 In Review to ✅ Done in Services Team Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants