Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate fromString method in PrivateKey #1661

Open
rokn opened this issue Dec 7, 2023 · 2 comments
Open

Deprecate fromString method in PrivateKey #1661

rokn opened this issue Dec 7, 2023 · 2 comments

Comments

@rokn
Copy link

rokn commented Dec 7, 2023

No description provided.

@thenswan thenswan self-assigned this Dec 7, 2023
@Petyo-Lukanov Petyo-Lukanov added this to the 2.34.0 milestone May 29, 2024
@thenswan
Copy link
Contributor

For reference:

I reproduced same scenario in Java SDK of getting an error only when using an ECDSA HEX encoded private key. But would like to mention a couple of points to discuss them before opening relevant PR:

  • PrivateKey.fromString() has a lot of usages in examples and tests -- should they be updated along with deprecation? (Similar situation in Go SDK)
  • there is also a PrivateKey.fromBytes() method, which may give an error on some valid key -- should we consider its deprecation in SDKs as well?

Although deprecation of PrivateKey.fromString() is straightforward, would like to call this out to refresh our memory on a PrivateKey class and review consistency across all of the SDKs in it.

cc @agadzhalov

@SimiHunjan SimiHunjan removed this from the 2.34.0 milestone Jun 11, 2024
@thenswan
Copy link
Contributor

thenswan commented Aug 7, 2024

Try to introduce a fix here.

@0xivanov 0xivanov added the good first issue candidate Issues that can become a good first issue but need more description/context. label Sep 3, 2024
@0xivanov 0xivanov added good first issue Issues which are ideal for a first time or new project contributor. and removed good first issue candidate Issues that can become a good first issue but need more description/context. good first issue Issues which are ideal for a first time or new project contributor. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants