Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractCreateFlow creates a file for smaller initcode #945

Open
0xivanov opened this issue May 30, 2024 · 0 comments
Open

ContractCreateFlow creates a file for smaller initcode #945

0xivanov opened this issue May 30, 2024 · 0 comments
Assignees
Labels
backlog enhancement New feature or request

Comments

@0xivanov
Copy link
Contributor

Problem

The ContractCreateFlow does not take advantage of newer features of HAPI to reduce the number and cost of transactions. Same issue in all SDKs.

Solution

  • The initcode file is created unconditionally instead of directly using ContractCreateTransaction.bytecode if it fits within a single transaction. File append and delete would likewise not be needed if bytecode is populated.
  • FileCreateTransaction partial bytecode is limited to 2048 instead of a larger size closer to max HAPI size 6 KiB
  • FileAppendTransaction sets chunk size to 2048 instead of a size closer to max HAPI size 6 KiB

Alternatives

No response

@0xivanov 0xivanov added the enhancement New feature or request label May 30, 2024
@0xivanov 0xivanov self-assigned this May 30, 2024
@Petyo-Lukanov Petyo-Lukanov modified the milestones: 2.38.0, 2.39.0 Jun 4, 2024
@SimiHunjan SimiHunjan removed this from the 2.39.0 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants