Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add integration test for NodeCreateTransaction #1102

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gsstoykov
Copy link
Contributor

@gsstoykov gsstoykov commented Oct 10, 2024

Description:
This PR serves as a POC for using NodeCreateTransaction.

Related issue(s):

Fixes #1085

Notes for reviewer:
Can be merged even if POC as it adds an Integration test. CI will fail against local-node so the test will be disabled(It needs Solo configured in our CI).

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@gsstoykov gsstoykov added the enhancement New feature or request label Oct 10, 2024
@gsstoykov gsstoykov added this to the v2.48.0 milestone Oct 10, 2024
@gsstoykov gsstoykov self-assigned this Oct 10, 2024
@gsstoykov gsstoykov requested review from a team as code owners October 10, 2024 10:30
@gsstoykov gsstoykov linked an issue Oct 10, 2024 that may be closed by this pull request
@gsstoykov gsstoykov marked this pull request as draft October 10, 2024 10:32
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37%. Comparing base (c3b73b2) to head (cac12b5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   73.37%   73.37%           
=======================================
  Files         174      174           
  Lines       24997    24997           
=======================================
  Hits        18342    18342           
  Misses       5909     5909           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gsstoykov <[email protected]>
Copy link

sonarcloud bot commented Oct 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test NodeCreateTransaction with Solo
2 participants