Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recovery id calculation when signing ethereum call transactions #684

Open
11 tasks
Petyo-Lukanov opened this issue Apr 23, 2024 · 2 comments
Open
11 tasks
Labels
good first issue candidate Issues that can become a good first issue but need more description/context.

Comments

@Petyo-Lukanov
Copy link

Petyo-Lukanov commented Apr 23, 2024

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hedera or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'good first issue' is to help you make your first contribution to Hedera.

👾 Description of the issue

Problem

Currently there is no way to calculate recovery id (v) when we sign an Ethereum Transaction from the SDK.

Solution

The recovery ID is an index from 0 to 3, which indicates which of the 4 possible public keys is the correct one. Because the key recovery operation yields multiple potential public keys, the correct key must either be stored alongside the signature or you must be willing to try each recovery ID in turn until you find one that outputs the key you are expecting.

Recovery operation is described in SEC1v2, section 4.1.6.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hedera developer community for support.
  • Wait for reviews: Members of the Hedera developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hedera community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@gsstoykov gsstoykov added this to the 0.27.0 milestone May 31, 2024
@rwalworth rwalworth modified the milestones: 0.27.0, 0.28.0 Jun 13, 2024
@gsstoykov
Copy link
Contributor

OpenSSL is not currently supporting the RecID generation it has been added as an issue in OpenSSL repo. This is not worth the effort at this point as it would need lots of custom implementations that could be deprecated on a certain OpenSSL release.

@gsstoykov
Copy link
Contributor

Moving to backlog for now.

@gsstoykov gsstoykov removed this from the 0.28.0 milestone Jun 17, 2024
@gsstoykov gsstoykov removed their assignment Sep 13, 2024
@gsstoykov gsstoykov added the good first issue candidate Issues that can become a good first issue but need more description/context. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue candidate Issues that can become a good first issue but need more description/context.
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants