Update node weight #272
Closed
Update node weight #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neeharika-Sompalli
requested review from
povolev15,
mgoelswirlds and
tinker-michaelj
services/node_stake_update.proto
Outdated
| /** | ||
| * The consensus weight of this node in the network. This is computed based on the stake of this node | ||
| * at midnight UTC of the current day. If the stake of this node is less than minStake, then the | ||
| * weight is 0. Sum of all weights of nodes in the network should be less than 500. |
There was a problem hiding this comment.
I might tweak this to give a little more context,
The network normalizes the weights of nodes above minStake so that the total sum of
weight is approximately 500. Specifically, the weight of a node A with stake > minStake
is computed using integer arithmetic as,
A_weight = Math.max((# of whole hbars staked by A) * 500 / (total # of whole hbars staked), 1)
so that every node above minStake has weight at least 1; but any node that has staked
at least 1 out of every 250 whole hbars staked will have weight >= 2.
There was a problem hiding this comment.
Thanks @tinker-michaelj . Updated
tinker-michaelj
previously approved these changes
Apr 21, 2023
Neeharika-Sompalli
requested review from
nickpoorman,
steven-sheehy,
xin-hedera,
tinker-michaelj,
poulok and
rbair23
xin-hedera
reviewed
Apr 21, 2023
| @@ -112,7 +112,7 @@ message NodeStake { | |||
| int64 reward_rate = 4; | |||
|
|
|||
| /** | |||
| * Consensus weight of this node for the new staking period. | |||
| * Total stake (rewarded and not rewarded) of this node at the beginning of the new staking period. | |||
There was a problem hiding this comment.
it's true only when min_stake <= stake_rewarded + stake_not_rewarded <= max_stake I believe. i.e. if the sum is less than min_stake, stake is 0; if the sum is more than max_stake, stake = max_stake
There was a problem hiding this comment.
Yeah just discussed with Nick and the same field can be used as the consensus weight .
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #271
Related to hashgraph/hedera-services#6204
Adds Consensus Weight to NodeStake to update mirror nodes with the staking info updated midnight UTC