chore: add maintainers as codeowners to all files #3335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PavelSBorisov <[email protected]>
Test Results 26 files + 3 413 suites +55 1h 4m 24s ⏱️ + 8m 19s For more details on these failures, see this check. Results for commit eb7797b. ± Comparison against base commit 2321aee. This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
andrewb1269hg
requested changes
Dec 13, 2024
Signed-off-by: PavelSBorisov <[email protected]>
|
andrewb1269hg
approved these changes
Dec 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 84.91% 84.98% +0.06%
==========================================
Files 69 69
Lines 4655 4655
Branches 1042 1042
==========================================
+ Hits 3953 3956 +3
+ Misses 397 394 -3
Partials 305 305
Flags with carried forward coverage won't be shown. Click here to find out more. |
rbarkerSL
requested changes
Dec 13, 2024
| @@ -2,21 +2,21 @@ | |||
| ##### Global Protection Rule ###### | |||
| ################################### | |||
| # NOTE: This rule is overriden by the more specific rules below. This is the catch-all rule for all files not covered by the more specific rules below | |||
| * @hashgraph/hedera-smart-contracts-product | |||
| * @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |||
There was a problem hiding this comment.
Suggested change
| * @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| * @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product |
Comment on lines
+10
to
+12
| /packages/relay/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | ||
| /packages/server/ @Nana-EC @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | ||
| /packages/ws-server/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts |
There was a problem hiding this comment.
Suggested change
| /packages/relay/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /packages/server/ @Nana-EC @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /packages/ws-server/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /packages/relay/ @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product | |
| /packages/server/ @Nana-EC @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product | |
| /packages/ws-server/ @georgi-l95 @Ivo-Yankov @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product |
Comment on lines
+17
to
+19
| /dapp-example/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | ||
| /k6/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | ||
| /tools/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts |
There was a problem hiding this comment.
Suggested change
| /dapp-example/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /k6/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /tools/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /dapp-example/ @georgi-l95 @Ivo-Yankov @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product | |
| /k6/ @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product | |
| /tools/ @georgi-l95 @Ivo-Yankov @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product |
| @@ -26,15 +26,15 @@ | |||
|
|
|||
| # Protection Rules for Github Configuration Files and Actions Workflows | |||
| /.github/ @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers | |||
| /.github/workflows/ @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @AlfredoG87 @ebadiere @Nana-EC @hashgraph/hedera-smart-contracts-product | |||
| /.github/workflows/ @Nana-EC @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |||
There was a problem hiding this comment.
Suggested change
| /.github/workflows/ @Nana-EC @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts | |
| /.github/workflows/ @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product |
Comment on lines
+35
to
+36
| /README.md @Nana-EC @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts | ||
| **/LICENSE @hashgraph/release-engineering-managers |
There was a problem hiding this comment.
Suggested change
| /README.md @Nana-EC @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts | |
| **/LICENSE @hashgraph/release-engineering-managers | |
| /README.md @Nana-EC @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product | |
| **/LICENSE @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts-managers |
Comment on lines
+39
to
+40
| **/.gitignore @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts | ||
| **/.gitignore.* @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts |
There was a problem hiding this comment.
Suggested change
| **/.gitignore @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts | |
| **/.gitignore.* @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts | |
| **/.gitignore @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product | |
| **/.gitignore.* @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update CODEOWNERS to provide maintainers ownership of all files in their repos
Related issue(s):
Fixes #10
Notes for reviewer:
N/A
Checklist