Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A series of small changes to stabilize tests #3242

Closed
wants to merge 2 commits into from

Conversation

ebadiere
Copy link
Contributor

Description:
This PR adds the checking of connection as part of a connection handling process for the afterEach hook in the tests. It also removes a Utils.wait by resolving a promise before continuing, and adds some gas deviation.

Related issue(s):

Fixes #3204

…nection handling

to address flaky tests.

Signed-off-by: Eric Badiere <[email protected]>
@ebadiere ebadiere self-assigned this Nov 10, 2024
@ebadiere ebadiere added the bug Something isn't working label Nov 10, 2024
@ebadiere ebadiere added this to the 0.60.0 milestone Nov 10, 2024
Copy link

github-actions bot commented Nov 10, 2024

Test Results

   23 files  + 22  338 suites  +329   1h 27m 25s ⏱️ + 1h 26m 48s
  588 tests +582  538 ✅ +532  4 💤 +4   46 ❌ + 46 
1 046 runs  +984  913 ✅ +851  6 💤 +6  127 ❌ +127 

For more details on these failures, see this check.

Results for commit 8a9d0c4. ± Comparison against base commit 3bd07ef.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere marked this pull request as draft November 11, 2024 18:29
@quiet-node quiet-node modified the milestones: 0.60.0, 0.61.0 Nov 11, 2024
tests running against servers running locally.

Signed-off-by: Eric Badiere <[email protected]>
Copy link

sonarcloud bot commented Nov 12, 2024

@quiet-node quiet-node modified the milestones: 0.61.0, 0.62.0 Nov 26, 2024
@quiet-node
Copy link
Member

The team will triage and address this in upcoming sprints. Thanks for the great work @ebadiere!

@quiet-node quiet-node closed this Nov 26, 2024
@quiet-node quiet-node removed this from the 0.62.0 milestone Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.85%. Comparing base (3bd07ef) to head (8a9d0c4).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3242      +/-   ##
==========================================
- Coverage   83.17%   77.85%   -5.32%     
==========================================
  Files          66       66              
  Lines        4314     4453     +139     
  Branches      843      993     +150     
==========================================
- Hits         3588     3467     -121     
- Misses        483      613     +130     
- Partials      243      373     +130     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.59% <ø> (-6.71%) ⬇️
server 83.28% <ø> (-0.25%) ⬇️
ws-server 36.66% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 20 files with indirect coverage changes

@quiet-node quiet-node added this to the 0.61.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket release acceptance tests are flaky
2 participants