Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add maintainers as codeowners to all files #3335

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add maintainers as codeowners to all files #3335

wants to merge 2 commits into from
+13 −13

Conversation

PavelSBorisov
Copy link
Member

Description:
Update CODEOWNERS to provide maintainers ownership of all files in their repos

Related issue(s):

Fixes #10

Notes for reviewer:
N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@PavelSBorisov PavelSBorisov self-assigned this Dec 13, 2024
@PavelSBorisov PavelSBorisov requested review from a team as code owners December 13, 2024 12:23
@PavelSBorisov PavelSBorisov linked an issue Dec 13, 2024 that may be closed by this pull request
Add Repo Maintainers to CODEOWNERS file #3320
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

Test Results

   26 files  + 3  413 suites  +55   1h 4m 24s ⏱️ + 8m 19s
  614 tests + 3  604 ✅ + 5  4 💤 ±0   6 ❌  - 2 
1 000 runs  +74  981 ✅ +79  9 💤 +1  10 ❌  - 6 

For more details on these failures, see this check.

Results for commit eb7797b. ± Comparison against base commit 2321aee.

This pull request removes 1 and adds 4 tests. Note that renamed tests count towards both. 
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes"

"before all" hook for "should execute "eth_getCode" for hts token" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode "before all" hook for "should execute "eth_getCode" for hts token"
"before all" hook for "should individually update amountSpents of different spending plans" ‑ RPC Server Acceptance Tests Acceptance tests @hbarlimiter HBAR Limiter Acceptance Tests HBAR Rate Limit Tests HBAR Rate Limit For Different Spending Plan Tiers @hbarlimiter-batch1 Multiple users with different tiers "before all" hook for "should individually update amountSpents of different spending plans"
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before each" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance "before each" hook for "reverts"

♻️ This comment has been updated with latest results.

andrewb1269hg
andrewb1269hg requested changes Dec 13, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@andrewb1269hg andrewb1269hg added this to the 0.63.0 milestone Dec 13, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.98%. Comparing base (b5e747f) to head (eb7797b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
+ Coverage   84.91%   84.98%   +0.06%     
==========================================
  Files          69       69              
  Lines        4655     4655              
  Branches     1042     1042              
==========================================
+ Hits         3953     3956       +3     
+ Misses        397      394       -3     
  Partials      305      305
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.75% <ø> (ø)
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

rbarkerSL
rbarkerSL requested changes Dec 13, 2024
View reviewed changes
.github/CODEOWNERS
@@ -2,21 +2,21 @@
##### Global Protection Rule ######
###################################
# NOTE: This rule is overriden by the more specific rules below. This is the catch-all rule for all files not covered by the more specific rules below
* @hashgraph/hedera-smart-contracts-product
* @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
* @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product

.github/CODEOWNERS
Comment on lines +10 to +12
/packages/relay/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/packages/server/ @Nana-EC @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/packages/ws-server/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/packages/relay/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/packages/server/ @Nana-EC @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/packages/ws-server/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/packages/relay/ @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product
/packages/server/ @Nana-EC @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product
/packages/ws-server/ @georgi-l95 @Ivo-Yankov @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product

.github/CODEOWNERS
Comment on lines +17 to +19
/dapp-example/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/k6/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/tools/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/dapp-example/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/k6/ @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/tools/ @georgi-l95 @Ivo-Yankov @hashgraph/devops-ci @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/dapp-example/ @georgi-l95 @Ivo-Yankov @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product
/k6/ @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product
/tools/ @georgi-l95 @Ivo-Yankov @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product

.github/CODEOWNERS
@@ -26,15 +26,15 @@

# Protection Rules for Github Configuration Files and Actions Workflows
/.github/ @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers
/.github/workflows/ @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @AlfredoG87 @ebadiere @Nana-EC @hashgraph/hedera-smart-contracts-product
/.github/workflows/ @Nana-EC @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/.github/workflows/ @Nana-EC @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts
/.github/workflows/ @hashgraph/devops-ci @hashgraph/devops-ci-committers @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product

.github/CODEOWNERS
Comment on lines +35 to +36
/README.md @Nana-EC @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts
**/LICENSE @hashgraph/release-engineering-managers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/README.md @Nana-EC @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts
**/LICENSE @hashgraph/release-engineering-managers
/README.md @Nana-EC @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product
**/LICENSE @hashgraph/release-engineering-managers @hashgraph/hedera-smart-contracts-managers

.github/CODEOWNERS
Comment on lines +39 to +40
**/.gitignore @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts
**/.gitignore.* @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**/.gitignore @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts
**/.gitignore.* @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts
**/.gitignore @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product
**/.gitignore.* @Nana-EC @hashgraph/release-engineering @hashgraph/release-engineering-managers @hashgraph/devops-ci @hashgraph/hedera-smart-contracts @hashgraph/hedera-smart-contracts-product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbarkerSL rbarkerSL rbarkerSL requested changes

@andrewb1269hg andrewb1269hg andrewb1269hg approved these changes

@dalvizu dalvizu Awaiting requested review from dalvizu dalvizu is a code owner automatically assigned from hashgraph/devops-ci

@matteriben matteriben Awaiting requested review from matteriben matteriben is a code owner automatically assigned from hashgraph/release-engineering

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

Requested changes must be addressed to merge this pull request.

Assignees

@PavelSBorisov PavelSBorisov

Labels
Audit
Projects
None yet
Milestone
0.63.0
Development

Successfully merging this pull request may close these issues.

Add Repo Maintainers to CODEOWNERS file Implement eth_call
3 participants
@PavelSBorisov @rbarkerSL @andrewb1269hg