You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First issue: Tests in the HBAR Limiter acceptance suite share and rely on the total HBAR budget controlled by the HbarLimitService class, with all expense additions occurring asynchronously in the background to avoid unnecessary wait time. As a result, the HBAR Limiter acceptance test requires a wait period after each test to allow the Relay sufficient time to properly update the burnt HBAR. This effectively adds wait_time * number_of_tests (ms) to the execution runtime, slowing down the entire process.
Second issue: Some tests in the HBAR Limiter acceptance suite rely on a tolerance, defined by TEST_TRANSACTION_RECORD_COST_TOLERANCE, to calculate the difference between total transaction costs with and without record query fees. This is because the test makes query calls to the consensus network, which adds query fees to the total HBAR limit. However, there is an option to make query calls to the mirror node by disabling the GET_RECORD_DEFAULT_TO_CONSENSUS_NODE flag, which could potentially eliminate the need for this tolerance.
Solution
First issue: Come up with a better polling solution to get the correct amount of the remaining HBARs
Second issue: Turn off the GET_RECORD_DEFAULT_TO_CONSENSUS_NODE and align the tests where necessary
Alternatives
No response
The text was updated successfully, but these errors were encountered:
Problem
First issue: Tests in the HBAR Limiter acceptance suite share and rely on the total HBAR budget controlled by the
HbarLimitService
class, with all expense additions occurring asynchronously in the background to avoid unnecessary wait time. As a result, the HBAR Limiter acceptance test requires a wait period after each test to allow the Relay sufficient time to properly update the burnt HBAR. This effectively addswait_time
*number_of_tests
(ms) to the execution runtime, slowing down the entire process.Second issue: Some tests in the HBAR Limiter acceptance suite rely on a tolerance, defined by
TEST_TRANSACTION_RECORD_COST_TOLERANCE
, to calculate the difference between total transaction costs with and without record query fees. This is because the test makes query calls to the consensus network, which adds query fees to the total HBAR limit. However, there is an option to make query calls to the mirror node by disabling theGET_RECORD_DEFAULT_TO_CONSENSUS_NODE
flag, which could potentially eliminate the need for this tolerance.Solution
GET_RECORD_DEFAULT_TO_CONSENSUS_NODE
and align the tests where necessaryAlternatives
No response
The text was updated successfully, but these errors were encountered: