Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce commons module #233

Open
ata-nas opened this issue Oct 7, 2024 · 0 comments
Open

refactor: introduce commons module #233

ata-nas opened this issue Oct 7, 2024 · 0 comments
Assignees
Labels
Improvement Code changes driven by non business requirements

Comments

@ata-nas
Copy link

ata-nas commented Oct 7, 2024

Problem

Generally every project has utility classes which are usually just full of static methods. Also, there are most likely "precondition" classes which are again full of static methods that aim to check for certain preconditions. Also, there are classes with constants that could be used in more than one place.

Since we have a few subprojects which are technically in different modules, we have no way (or at least not a good one) to reuse this logic. Some logic will be relevant in more than one place. There is no need to duplicate this logic. Also it makes little sense to depend on a subproject just to use it's utilities (and sometimes such dependencies might be impossible).

Solution

  • create a new commons module;
  • abstract all logic that could be reused (as described in Problem), based on classes above;
  • refactor all places to facilitate the new logic;

Alternatives

N/A

@ata-nas ata-nas added the Improvement Code changes driven by non business requirements label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant