Skip to content
This repository has been archived by the owner on Dec 12, 2019. It is now read-only.

Different defaults for Drupal 8 #305

Open
wizonesolutions opened this issue Nov 14, 2015 · 11 comments
Open

Different defaults for Drupal 8 #305

wizonesolutions opened this issue Nov 14, 2015 · 11 comments

Comments

@wizonesolutions
Copy link
Contributor

One thing that would help is if, through one variable, we could auto-change a number of defaults in provisioning. For example, for D8 we should use PHP 5.6 (or PHP 7?), clone Drush master, perhaps install Drupal Console, etc. Maybe an easy first pass as this is to have an example-8.settings.yml?

What do you think?

@philipnorton42
Copy link
Contributor

I've had something like this in mind for a while, in fact I think there was either an issue or a discussion about it at some point but it never got any further.

I think creating a D8 settings.yml file is a great idea though, especially as we move into the D8 release phase. I have to admit that when I know I'll be working on a D8 site it takes me a few minutes to collate all of the settings needed.

I've found that the best settings for D8 are to add the following:

  drush_version: master
  vm_memory: 2048

D8 needs a little more memory than usual so bumping that up slightly allows things to function well.

We'll also need to incorporate Drupal console into the system, but we need to make a role for that :)

@dixhuit
Copy link
Contributor

dixhuit commented Nov 15, 2015

We'll also need to incorporate Drupal console into the system, but we need to make a role for that :)

Or find a good one ;)

@philipnorton42
Copy link
Contributor

Well, as installing the Drupal Console is only two commands I've added it in now :)

@philipnorton42
Copy link
Contributor

I've added it in now

Actually, it's not complete. It needs to be much more idempotent.

@wizonesolutions
Copy link
Contributor Author

Is geerlingguy's role usable?
16. nov. 2015 11:39 skrev "Philip Norton" [email protected]:

I've added it in now

Actually, it's not complete. It needs to be much more idempotent.


Reply to this email directly or view it on GitHub
#305 (comment).

@philipnorton42
Copy link
Contributor

Actually, I didn't look to see if he had one, but having installed Drupal Console a couple of times now I went ahead and created a little role. It's only a couple of commands, one to download and another to make sure the command is available system-wide. Turns out our approaches weren't too dissimilar. I've added some idempotent rules to the task now so it behaves much better.
He's got a nice auto-updating task that I have adapted for use in the new role.

@wizonesolutions
Copy link
Contributor Author

Awesome, I'll likely be using that soon.
16. nov. 2015 12:56 skrev "Philip Norton" [email protected]:

Actually, I didn't look to see if he had one, but having installed Drupal
Console a couple of times now I went ahead and created a little role. It's
only a couple of commands, one to download and another to make sure the
command is available system-wide. Turns out our approaches weren't too
dissimilar. I've added some idempotent rules to the task now so it behaves
much better.
He's got a nice auto-updating task that I have adapted for use in the new
role.


Reply to this email directly or view it on GitHub
#305 (comment).

@dixhuit
Copy link
Contributor

dixhuit commented Nov 26, 2015

I think what we really could do with is a variable for which major core version you intend to use with the VM. Fresh from committing a change to help address #310 our default drush commands (drush_install_commands) were causing problems:

  1. registry_rebuild doesn't have a stable D8 release and apparently isn't as much of a necessity in D8 development
  2. coder was specifying a D7 version

Both of those issues have now been addressed but I also noticed that site_audit doesn't have a stable D6 version! That was the proverbial straw that broke the camel's back and sent me straight back to this very issue.

Separate D8 defaults isn't enough IMHO, we might as well scale this idea a bit more and build a system for different defaults for any version major core version.

@zxaos
Copy link
Contributor

zxaos commented Dec 2, 2015

Sufficient separation of build process would also allow you to do things like conditionally install twig (i.e. #294 ) which is useful for 8 but a waste of build time for 7.

@zxaos
Copy link
Contributor

zxaos commented Dec 7, 2015

Here's something I've been thinking about.

If you end up building drupal 8 projects with composer the way that https://github.com/drupal-composer/drupal-project recommends, you'll already have a copy of both drush and drupal_console by the time you're provisioning the machine (unless you want to do some magic and also run composer install for D8 projects, which might arguably be cool). Given that the current drupal_console role is causing problems ( #308 #314 #316 ) maybe it'd be better to just drop it?

@dixhuit
Copy link
Contributor

dixhuit commented Dec 8, 2015

Drupal Console is disabled in dev for now: 8989a05

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants