Some system settings are not allowed during the IPXE installation #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
force-pushed
the
issue_6329_system_settings
branch
from
6ab9302 to
a3fbc8a
Compare
Relates to: harvester/harvester#6329 Signed-off-by: Volker Theile <[email protected]>
votdev
force-pushed
the
issue_6329_system_settings
branch
from
a3fbc8a to
4dc9b04
Compare
bk201
approved these changes
Aug 14, 2024
|
@Mergifyio backport v1.4 v1.3 |
✅ Backports have been created
|
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We have an allow list in the installer:
harvester-installer/pkg/config/config.go
Line 41 in 14913a9
Solution:
Add the missing supported system settings.
Related Issue:
harvester/harvester#6329
Test plan:
Do an IPXE Install and add a missing system setting like
auto-rotate-rke2-certs. The installation should not fail.This can be done easily by adding the setting to the file vagrant-pxe-harvester/ansible/roles/harvester/templates/config-create.yaml.j2