Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rancherd-12-monitoring-dashboard.yaml #639

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

ulikl
Copy link
Contributor

@ulikl ulikl commented Jan 19, 2024

Problem:
The panel titles "Network Receive Bytes" and "Network Transmit Bytes" are a bit misleading as the values are in Bits/s. And Storage Write Traffic Bytes" is really in Bytes/s.
See expr : "metrics* 8!"
The units where already correctly shown in "MB/s".

Solution:
Rename panel titles to "Bits"

Related Issue:

The titles "Network Receive Bytes" and "Network Transmit Bytes" are a bit misleading as the values are in Bits/s. And Storage Write Traffic Bytes" is really in Bytes/s.
 See expr :" metrics* 8!"
The units was already correctly shown in "MB/s".
@bk201 bk201 requested a review from w13915984028 January 22, 2024 07:47
@bk201
Copy link
Member

bk201 commented Jan 22, 2024

@w13915984028 I'm not entirely sure, but this perhaps better fix in upstream

Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @ulikl thanks very much for this PR.

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

@w13915984028 w13915984028 merged commit df9454c into harvester:master Feb 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants