From 21679efdfcabfb117dd136967c4531f9cd7217ec Mon Sep 17 00:00:00 2001 From: Gaurav Mehta Date: Thu, 5 Sep 2024 17:14:36 +1000 Subject: [PATCH] minor change to disable multipath via kernel arguments when no external storage config is present. This ensures initrd does not load it before switching rootfs and avoids unwanted side effect of /dev/mapper devices for disks being created --- pkg/console/util.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/console/util.go b/pkg/console/util.go index a00937553..c5fbd72e1 100644 --- a/pkg/console/util.go +++ b/pkg/console/util.go @@ -50,6 +50,7 @@ You can see the full installation log by: ElementalConfigDir = "/tmp/elemental" ElementalConfigFile = "config.yaml" + multipathOff = "multipath=off" ) func newProxyClient() http.Client { @@ -504,6 +505,9 @@ func doInstall(g *gocui.Gui, hvstConfig *config.HarvesterConfig, webhooks Render env = append(env, fmt.Sprintf("HARVESTER_DATA_DISK=%s", hvstConfig.DataDisk)) } + if !hvstConfig.OS.ExternalStorage.Enabled { + env = append(env, fmt.Sprintf("HARVESTER_ADDITIONAL_KERNEL_ARGUMENTS=%s", multipathOff)) + } if hvstConfig.OS.AdditionalKernelArguments != "" { env = append(env, fmt.Sprintf("HARVESTER_ADDITIONAL_KERNEL_ARGUMENTS=%s", hvstConfig.OS.AdditionalKernelArguments)) }