Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max Score on PageSpeed Insights #8

Closed
harsxv opened this issue Sep 5, 2024 · 5 comments · Fixed by #40
Closed

Max Score on PageSpeed Insights #8

harsxv opened this issue Sep 5, 2024 · 5 comments · Fixed by #40
Assignees
@atinder-harika
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted

Comments

@harsxv
Copy link
Owner

harsxv commented Sep 5, 2024 •
edited
Loading

Hello!

I opened this good first issue to help first-time contributors get started.

The score on PageSpeed Insights can be improved to achieve a maximum score of 💯

Files can be checked:

  • index.html.theme
  • history.html.theme

It’s really just a matter of color contrast. I’ve adjusted it to pass the check here: https://dequeuniversity.com/rules/axe/4.9/color-contrast, but I’m not fond of the dark green against the background.

contrast analyzer darker green result
image image

Maybe someone with a stronger sense of UI/UX can help improve this. I’d appreciate your contribution!

Score currently: https://pagespeed.web.dev/analysis/https-status-harry-id/3bfccw1chu

Screenshot 2024-09-05 at 22 51 07
@harsxv harsxv added the good first issue Good for newcomers label Sep 5, 2024
@Radbluelite
Copy link

Can I work on this issue to improve the accessiblity?

@harsxv
Copy link
Owner Author

harsxv commented Oct 6, 2024

Yes of course. I will assign the issue. Thank you!

@atinder-harika
Copy link
Contributor

@harsxv Since there have been no pr's for this issue I would be glad to contribute, I have good experince with UI/UX in general.

@harsxv
Copy link
Owner Author

harsxv commented Oct 28, 2024

@atinder-harika sure, I've assigned to you. Thanks!

@harsxv harsxv assigned atinder-harika and unassigned Radbluelite Oct 28, 2024
@atinder-harika atinder-harika mentioned this issue Oct 30, 2024
Merged
@atinder-harika
Copy link
Contributor

@harsxv I made PR #40, resolving this issue.

@harsxv harsxv linked a pull request Oct 31, 2024 that will close this issue
Studied the Contrast Ratio of the color and made changes #40
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atinder-harika atinder-harika

Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Studied the Contrast Ratio of the color and made changes atinder-harika/tinystatus
3 participants
@harsxv @atinder-harika @Radbluelite