Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong PIN(s) #7

Open
harshil21 opened this issue Oct 5, 2020 · 0 comments · May be fixed by #6
Open

Wrong PIN(s) #7

harshil21 opened this issue Oct 5, 2020 · 0 comments · May be fixed by #6
Assignees
@harshil21
Labels
bug Something isn't working invalid This doesn't seem right
Milestone
v0.6

Comments

@harshil21
Copy link
Owner

harshil21 commented Oct 5, 2020 •
edited
Loading

The preferred IUPAC name for CH~CH is acetylene and not Eth-1-yne. (P-31.1.2.1 - Retained names)

Also carbonpy currently capitalizes all compound names which isn't recommended either.

Will be fixed by #6
@harshil21 harshil21 linked a pull request Oct 5, 2020 that will close this issue
Support for branches and much more #6
Open
14 tasks
@harshil21 harshil21 self-assigned this Oct 6, 2020
@harshil21 harshil21 added bug Something isn't working invalid This doesn't seem right labels Oct 6, 2020
@harshil21 harshil21 added this to the v0.6 milestone Oct 6, 2020
harshil21 added a commit that referenced this issue Oct 8, 2020
@harshil21
Fixed #7, remove 20 carbon limit
081e3b5 
- Now derive carbon prefixes using the method described in P-14.2.1.2. This removes 20 carbon limit and now allows naming upto 10,000 carbon atoms.

- Fixed #7

- Moved compound.py and element.py into base dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshil21 harshil21

Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Support for branches and much more harshil21/carbonpy
1 participant
@harshil21