Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compartmentalize. #62

Open
harrisi opened this issue May 13, 2017 · 2 comments
Open

Compartmentalize. #62

harrisi opened this issue May 13, 2017 · 2 comments

Comments

@harrisi
Copy link
Owner

harrisi commented May 13, 2017

No description provided.

@harrisi
Copy link
Owner Author

harrisi commented May 13, 2017

I'm not sure what this is referencing.

@ghost
Copy link

ghost commented May 13, 2017

If it makes no sense you should probably not add it. This is referring to the lines immediately below it,

for (auto &c : initial_glyphs)
    book[string(1, c)] = glyph(face, (FT_ULong)c);

Suggesting that a bare map may not be the best way to store the glyph cache, but it's the best I can come up with without just adding a bunch of boilerplate that wraps it in a class.

A useful title might include something related to UTF-8 normalization which is necessary at some point (e.g. turn multipoint sequences into their condensed forms where appropriate, eliminating combining characters). See here under "Combining Characters." Or this could just be closed and a separate issue opened up for that one - it should be in a comment somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant