Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete files ignored by .gitignore #2

Open
KPJoshi opened this issue Sep 29, 2015 · 5 comments
Open

Delete files ignored by .gitignore #2

KPJoshi opened this issue Sep 29, 2015 · 5 comments

Comments

@KPJoshi
Copy link
Contributor

KPJoshi commented Sep 29, 2015

Although .gitignore has been added, the files ignored by it are still in the GitHub repo. They will have to be removed.

@harpreetrathore
Copy link
Owner

Hey thanks for your review. But I think we should not delete those files as we don't want to run builder again and again. If you see any other atoms module, in them only loader is executed.

@KPJoshi
Copy link
Contributor Author

KPJoshi commented Sep 29, 2015

OK, it is just that git is meant for version control of source, not binaries.
I believe that what is usually done is a compiled binary release version is made available separately as a .zip/.tar.gz file, and only code is kept on GitHub
The rationale is this: the same code might have to be compiled by different compilers on different systems. Keeping the binaries on GitHub will force the others to download these useless binaries and then rebuild them anyways.
But finally it is up to you.

@harpreetrathore
Copy link
Owner

Hey, thanks for pointing it out as I am new to git. But you know sometime I have to give demos to managers & professors and I want it to run as it is on atoms. And If I include binaries it will just increase 1 or 2 MB in the package thats not an issue I think

@harpreetrathore
Copy link
Owner

Hey I was going through your code they will also ignore the third party files. And I don't want that because it will increase the dependency for the package i.e. symphony and ipopt which also have further dependencies.

@KPJoshi
Copy link
Contributor Author

KPJoshi commented Sep 29, 2015

OK. In that case, only keep the 'temporary files' and the 'other' sections. You should delete the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants