Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome crash removes all wallets #96

Open
bmgalego opened this issue Apr 24, 2021 · 0 comments
Open

Chrome crash removes all wallets #96

bmgalego opened this issue Apr 24, 2021 · 0 comments

Comments

@bmgalego
Copy link

When chrome crashes sometimes it removes all wallets from the extension and it only happens to Harmony wallet, metamask for instance doesn't happen. I have tried to crash the chrome to see if happens but couldn't reproduce the same result so don't know how to test this. But I found some code in the metamask repo that may help this.

I think this is where harmony deletes the wallets
https://github.com/harmony-one/onewallet/blob/master/src/services/StorageService.js#L14

Metamask does something similiar
https://github.com/MetaMask/metamask-extension/blob/af3c740b1b4e3cbaf78611b98c6af95f51bfcae2/app/scripts/lib/local-store.js#L54
https://github.com/MetaMask/metamask-extension/blob/af3c740b1b4e3cbaf78611b98c6af95f51bfcae2/app/scripts/lib/util.js#L137

This is easy implemented and I it works for metamask, let me know if this is ok and I could make a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant