Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate keystore to Metamask eth-keyring-controller #123

Open
3 of 18 tasks
hashmesan opened this issue Feb 3, 2022 · 1 comment
Open
3 of 18 tasks

Migrate keystore to Metamask eth-keyring-controller #123

hashmesan opened this issue Feb 3, 2022 · 1 comment

Comments

@hashmesan
Copy link

Motivation

To improve security of the storage, I'm proposing to use eth-keyring-controller which provides a unified enclave like way to sign transaction. The enclave/controller prevents any leakage of privateKey, stores multiple type of keyring in a standard way, and provide proper lock & unlock (Lock removes all the private key in memory store, which makes secure!)

Tasks

  • evaluate the impact on the code
  • need event passing between popup & background for add/remove wallet, and get wallets
  • migrate function
  • migrate UI
  • add wallet functionality
  • serialization of keyring-controller and meta data
  • integrate wallets to the wallet menu UI
  • integrate wallets to export UI
  • integrate wallets to create UI
  • integrate wallets to import UI
  • signing transaction
  • test with stake/unstake
  • personal sign
  • lock / unlock functionality
  • regression testing on app
  • test for injected script (API)
  • alpha testing
  • build & release
@hypnagonia
Copy link
Contributor

@hashmesan nice proposal. we cease further wallet development and plan to migrate users to other wallets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants