Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To integrate a TOSUN CAN device #1873

Open
sy950915 opened this issue Oct 15, 2024 · 5 comments
Open

To integrate a TOSUN CAN device #1873

sy950915 opened this issue Oct 15, 2024 · 5 comments

Comments

@sy950915
Copy link

Hello, I am an employee of Shanghai Tongxing Intelligent Technology Co., Ltd. We are interested in integrating our company's device into Python-can. Currently, many users are requesting the ability to use our device directly within Python-can. At present, we achieve this by installing Python-can and then adding our own files into the Python-can directory to enable this functionality. However, this approach is not as seamless as having our device fully integrated into Python-can, and we are looking for a more convenient solution.

@zariiii9003
Copy link
Collaborator

Hi, you can create and publish your own package, which python-cans entry point as described here. We will add your package as an extra dependency and mention it in our documentation.

@sy950915
Copy link
Author

@zariiii9003 Hello, at the moment, our approach requires users to first install Python-can and then configure it manually in order to use our device. We would like to discuss the possibility of directly integrating our device into Python-can, so that users can install Python-can via pip and use our device without any additional configuration—similar to how Vector devices are supported.

@zariiii9003
Copy link
Collaborator

Your users would install your package as an extra dependency with pip install python-can[tosun]. No additional configuration necessary.

@sy950915
Copy link
Author

@zariiii9003
Alright, thank you very much. I will take some time to research this further. I greatly appreciate your response.

@luojiaaoo
Copy link
Contributor

I've manually added your compatible python file to python-can @sy950915 ,There were a few small problem. I changed some code manually for TOSUN.
I hope the next version of python-can, tosun will be officially supported. Python-can is the most popular library in python, so focus on it, (- v -)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants