You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Essentially, I'd like to purposely suppress messages like: [fcrdns] queryA ESERVFAIL jaana24.stonemarketing.com.br which are triggered by connection.results.add(plugin, {err: err2[e].message})
I don't think error level is appropriate for irrelevant things.
Or, better yet, just allow specifying the level, like results.add(plugin, {err: blah, log_level: 'info'})
What do you think?
The text was updated successfully, but these errors were encountered:
Results shouldn't be the arbiter of what is relevant.
Allowing a log level to be specified would be reasonable. It would still require modifying the caller. In the case you cited, wouldn't it be better to just modify the caller (fcrdns plugin) to: connection.results.add(plugin, {msg: err2[e].message})?
Wouldn't it be better -- I don't know. That will break any other plugin that relies on results structure set by respective plugin. I'll adjust fcrdns and submit a pull req. then. But still, allowing log_level to be set would be a wonderful addition. We can even call the param emit_log_level, to minimize the collision.
Essentially, I'd like to purposely suppress messages like:
[fcrdns] queryA ESERVFAIL jaana24.stonemarketing.com.br
which are triggered byconnection.results.add(plugin, {err: err2[e].message})
I don't think error level is appropriate for irrelevant things.
Or, better yet, just allow specifying the level, like
results.add(plugin, {err: blah, log_level: 'info'})
What do you think?
The text was updated successfully, but these errors were encountered: