Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning about not normalized quaternion #79

Open
Jiayuan-Gu opened this issue Jun 8, 2022 · 0 comments
Open

Add warning about not normalized quaternion #79

Jiayuan-Gu opened this issue Jun 8, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jiayuan-Gu
Copy link
Contributor

Eigen::Matrix3f rotMat; // TODO(jigu): Maybe there exists an easier way to write it

We have not check whether quaternion is normalized when we create Pose. And to_transformation_matrix can in-place modify q. Thus, we are going to add some warning and perhaps automatically normalize for users.

@Jiayuan-Gu Jiayuan-Gu added the enhancement New feature or request label Jun 8, 2022
@Jiayuan-Gu Jiayuan-Gu self-assigned this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant