Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaKernel annotation error #3

Open
fengluodb opened this issue Aug 26, 2022 · 1 comment
Open

MetaKernel annotation error #3

fengluodb opened this issue Aug 26, 2022 · 1 comment

Comments

@fengluodb
Copy link

I found some annotation error in MetaKernel.

  1. In forward, param coord_data: num_batch, 3, H, W link. But it's not real, in SalsaNextWithMotionAttention, coor_data is current_range_image, it's channel is 5;
  2. In sample_data , :return: sample_output: num_batch, num_channel_in * kernel_size * kernel_size, H, W, link. I think the outout should be num_batch, num_channel * kernel_size * kernel_size, HxW
@MaxChanger
Copy link
Member

Thank you for such meticulous coding review.
I took a quick look and recalled that this part of the annotation may be from the original RangeDet, which has not been carefully checked and modified.

  1. It really needs to be corrected here, because in fact, any dimension can be passed in here, (x, y, z), or (x, y, z, i, r)

    downCntx = self.metaConv(data=downCntx,
    coord_data=current_range_image,
    data_channels=downCntx.size()[1],
    coord_channels=current_range_image.size()[1],
    kernel_size=3)

  2. I think you might be right, I look further into docs doc_mxnet and doc_torch_nn.Unfold, and confirm the tensor shape/size when debugging.

These will be fixed and updated soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants