Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize danmaku matching for segment's skipping #113

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

xiaoxuan010
Copy link
Contributor

  • 我同意我的所有贡献将以GPL-3.0协议开源。

优化逻辑,匹配更多时间格式的弹幕。经测试,目前的逻辑可匹配以下类型的弹幕:
image

@xiaoxuan010 xiaoxuan010 force-pushed the optimize-danmaku-matching branch from ced1368 to 7931ef1 Compare December 26, 2024 08:20
@xiaoxuan010 xiaoxuan010 force-pushed the optimize-danmaku-matching branch from 7931ef1 to 1c70c89 Compare December 26, 2024 08:25
@hanydd
Copy link
Owner

hanydd commented Dec 27, 2024

话说你的test如果觉着有必要也可以合并进来

@xiaoxuan010
Copy link
Contributor Author

话说你的test如果觉着有必要也可以合并进来

因为这个函数可能涉及到运行时的Config设置,所以部分功能可能不太方便写测试。我先编写一个简单的测试环境待后续补充吧。

新增弹幕工具函数的测试
@hanydd hanydd merged commit 5ea3b4a into hanydd:master Dec 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants