Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height of the notification constraints #11

Open
sashazxtt opened this issue Jan 19, 2017 · 0 comments
Open

Height of the notification constraints #11

sashazxtt opened this issue Jan 19, 2017 · 0 comments

Comments

@sashazxtt
Copy link

It appears that the height of the notification must be an exact multiple of the animation steps. If it is not, then in moveNotificationAnimation() notificationWindow.setPosition will throw an exception

    at TypeError (native)
    at Timeout._repeat (C:\Users\t_kevinki\pulse-electron\app\node_modules\electron-notify\index.js:424:24)

That is because step will not be an integer if the height is not a multiple of steps. Maybe casting to int will fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant