Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samly.State.Store.get_assertion can actually get nil instead of assertion_key() #50

Open
aliaksandr-martsinovich opened this issue Nov 18, 2019 · 0 comments

Comments

@aliaksandr-martsinovich

Samly.State.Store.get_assetion's typespec is get_assertion(Conn.t(), assertion_key(), opts()) :: Assertion.t() | nil

But here we supply the function with the result of get_session(conn, "samly_assertion_key") which will return nil if "samly_assertion_key" key is not set.

I think this happens for the very first login attempt and obviously results in an exception.

@aliaksandr-martsinovich aliaksandr-martsinovich changed the title Samly.State.Store.get_assertion can actually get nil instead of assertion_key() Samly.State.Store.get_assertion can actually get nil instead of assertion_key() Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant