Implements more custom events, similar to jquery-ujs/rails-ujs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
I've opened this PR because I've found the vanilla-ujs custom events to be insufficient for the project I'm working on, I needed some of the events provided by jquery-ujs/rails-ujs.
Unfortunately this has meant changing the functionality of
ajax:beforewhich means that these changes couldn't be implemented without breaking the projects currently using this gem.So I just wanted to start a conversation really, is there any chance that these types of changes could be implemented in this gem, or would it perhaps make more sense to create an entirely new one?