Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Scala 2.11 #438

Open
ryan-williams opened this issue Apr 12, 2016 · 5 comments
Open

Upgrade to Scala 2.11 #438

ryan-williams opened this issue Apr 12, 2016 · 5 comments

Comments

@ryan-williams
Copy link
Member

Eventually we should do this; collecting notes about how/when here.

  • should we have a transition period where we support both?
  • or should we switch over in one go (once we're sure things work on 2.11)?

Based on only high-level knowledge of the ramifications, I'm in favor of the latter.

Some context / notes:

@arahuja
Copy link
Contributor

arahuja commented Apr 12, 2016

Also, a fan of the latter. Tried this in #433 but ran into some dependency issues (run time class not found errors),but I think I had just needed Spark compiled for the right scala version though and didn't test further

@ryan-williams
Copy link
Member Author

Cool, gtk! Also the impending move to Java 8 seems like a nudge toward Scala 2.11, as I've heard that Java 8 interactions with Scala 2.10 are possibly wonky.

@arahuja
Copy link
Contributor

arahuja commented Sep 1, 2016

@ryan-williams Have you given this a shot? I tried just changing the config and an error I got was

Error:(132, 47) diverging implicit expansion for type org.hammerlab.guacamole.reference.Position => Comparable[org.hammerlab.guacamole.reference.Position]
starting with method orderingToOrdered in object Ordered
      ReferenceRegion(contigName, start, end) <- rdd                                        ^

Seems to have to do with the val ordering defined in the Position companion object, but not sure how to proceed.

I'm guessing we will also need to handle hammerlab/magic-rdds#23 first?

@ryan-williams
Copy link
Member Author

I tried this once a little while ago; one issue I remember is that it was unclear whether Zinc / incremental compilation works in Scala 2.11? This may be happening on bigdatagenomics/adam#1142 atm too.

I think you're right about magic-rdds 2.11 support. I will start working on that soon, was thinking of that as a test-bed for how that process might work in guac anyway.

@ryan-williams
Copy link
Member Author

magic-rdds_2.11 versions have been live for several weeks so I don't think we have any remaining blockers here; #594 fixed some issues as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants