fix: fixes typo in EmailValidator #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urbanautomaton
pushed a commit
to futurelearn/valid_email
that referenced
this pull request
Jun 19, 2023
A typo in hallelujah#122 appears to have introduced an error here that's causing a large number of test failures. Closes hallelujah#124, closes hallelujah#123, fixes hallelujah#120
urbanautomaton
pushed a commit
to futurelearn/valid_email
that referenced
this pull request
Jun 19, 2023
A typo in hallelujah#122 appears to have introduced an error here that's causing a large number of test failures. Closes hallelujah#124, closes hallelujah#123
ritec
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
I was looking into some test failures after updating this gem to
0.1.4. I'm encountering the issue in #120.While looking at the master branch (to see if the changes there fixed #120), I noticed there were a lot of tests that were failing due to a chance introduced in #122.
It looks like the project doesn't have CI running, which could have detected this issue.