Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

verify workaround for self-referential module types #2

Open
hall opened this issue Aug 28, 2022 · 0 comments
Open

verify workaround for self-referential module types #2

hall opened this issue Aug 28, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@hall
Copy link
Owner

hall commented Aug 28, 2022

In 6dfa8e8, I've set any option whose type is its own module's type to unspecified. I'm opening this issue to go back, at some point, and verify that this is the correct approach (as doing so removes validation for any option which meets the definition).

This scenario occurs b/c the CRD type includes the JSONSchemaProps field which has fields (anyOf, allOf, oneOf, and not) of that same type; that is, JSONSchemaProps "appears in" JSONSchemaProps:

image
@hall hall mentioned this issue Aug 28, 2022
Closed
@hall hall added the help wanted Extra attention is needed label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hall