From 239a685d1c085b3e774017a6d52eda79dd84c227 Mon Sep 17 00:00:00 2001 From: Francis Duvivier Date: Tue, 8 Oct 2024 17:48:35 +0200 Subject: [PATCH 1/4] update github-pages-deploy-action to v4 --- .github/workflows/webusb-site.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/webusb-site.yml b/.github/workflows/webusb-site.yml index 0ec57d2..5ac07a5 100644 --- a/.github/workflows/webusb-site.yml +++ b/.github/workflows/webusb-site.yml @@ -18,9 +18,9 @@ jobs: yarn build cp CNAME dist/CNAME - name: Deploy 🚀 - uses: JamesIves/github-pages-deploy-action@3.7.1 + uses: JamesIves/github-pages-deploy-action@v4 with: - GITHUB_TOKEN: ${{ secrets.DEPLOY_PAT }} - BRANCH: gh-pages # The branch the action should deploy to. - FOLDER: webusb_site/dist # The folder the action should deploy. - CLEAN: true # Automatically remove deleted files from the deploy branch + token: ${{ secrets.DEPLOY_PAT }} + branch: gh-pages # The branch the action should deploy to. + folder: webusb_site/dist # The folder the action should deploy. + clean: true # Automatically remove deleted files from the deploy branch From d869e5c71418e4ecf1abaf1f75b1beaaa72da308 Mon Sep 17 00:00:00 2001 From: Francis Duvivier Date: Tue, 8 Oct 2024 20:20:09 +0200 Subject: [PATCH 2/4] remove token from Deploy action Since I don't find an option to make a token with code push permissions and actually I don't see a reason why not to just give the github actions push access in general via the settings and make use of that. --- .github/workflows/webusb-site.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/webusb-site.yml b/.github/workflows/webusb-site.yml index 5ac07a5..66ebf3e 100644 --- a/.github/workflows/webusb-site.yml +++ b/.github/workflows/webusb-site.yml @@ -20,7 +20,6 @@ jobs: - name: Deploy 🚀 uses: JamesIves/github-pages-deploy-action@v4 with: - token: ${{ secrets.DEPLOY_PAT }} branch: gh-pages # The branch the action should deploy to. folder: webusb_site/dist # The folder the action should deploy. clean: true # Automatically remove deleted files from the deploy branch From f43bfafdd843aa84dd1e168b4f21f075d6422034 Mon Sep 17 00:00:00 2001 From: Francis Duvivier Date: Tue, 8 Oct 2024 20:25:16 +0200 Subject: [PATCH 3/4] Add .tool-versions file for nodejs --- webusb_site/.tool-versions | 1 + 1 file changed, 1 insertion(+) create mode 100644 webusb_site/.tool-versions diff --git a/webusb_site/.tool-versions b/webusb_site/.tool-versions new file mode 100644 index 0000000..c2ca3d3 --- /dev/null +++ b/webusb_site/.tool-versions @@ -0,0 +1 @@ +nodejs 20.9.0 From 06e280109830a7f38331ab237aed44f717eb7499 Mon Sep 17 00:00:00 2001 From: Francis Duvivier Date: Tue, 8 Oct 2024 20:58:00 +0200 Subject: [PATCH 4/4] Change nodejs in asdf tool versions file to 16.19.0 to match node versions tested in actions --- webusb_site/.tool-versions | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webusb_site/.tool-versions b/webusb_site/.tool-versions index c2ca3d3..d82b78e 100644 --- a/webusb_site/.tool-versions +++ b/webusb_site/.tool-versions @@ -1 +1 @@ -nodejs 20.9.0 +nodejs 16.19.0