Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a job to push merges to main to our public Cachix cache #942

Closed
dhess opened this issue Apr 11, 2023 · 0 comments · Fixed by #1010
Closed

Add a job to push merges to main to our public Cachix cache #942

dhess opened this issue Apr 11, 2023 · 0 comments · Fixed by #1010
Assignees
Labels
caching Caching issue CI CI-related

Comments

@dhess
Copy link
Member

dhess commented Apr 11, 2023

Depends on #988.

Note that I considered just outright switching Primer CI to use our public Cachix cache for everything, not just merges to main. However, I think this would be a bad idea for a few reasons, including, but not limited to, the following:

  • We probably don't want to push work-in-progress build artifacts to the public cache. For example, we might accidentally leak a secret while working on a PR, or inadvertently use a dependency that contains a vulnerability.
  • Cachix caches don't grow unbounded, and most contributors won't care about work-in-progress build artifacts, so limiting the public cache to just the "final" artifacts will make better use of the available cache resources.

Instead, I think we can write a CI job that runs on every merge to main and pushes the Nix closure for main to the public cache.

@dhess dhess added this to the Open source release milestone Apr 11, 2023
@dhess dhess self-assigned this Apr 11, 2023
@dhess dhess changed the title Switch to our public Cachix cache Add a job to push merges to main to our public Cachix cache May 12, 2023
@dhess dhess added CI CI-related caching Caching issue labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
caching Caching issue CI CI-related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant